Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-18899

Enable fsyncLock on WiredTiger to allow backups via copy

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.9
    • Component/s: WiredTiger
    • Labels:
      None

      Description

      This could be enabled by taking a backup cursor during lock and releasing it during unlock.

      See: http://source.wiredtiger.com/develop/backup.html

        Issue Links

          Activity

          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'daveh86', u'name': u'David Hows', u'email': u'howsdav@gmail.com'}

          Message: SERVER-18899 - Add beginBackup and endBackup to storage API
          Branch: master
          https://github.com/mongodb/mongo/commit/e1d7404eae3a2c33fa4f15105b931f17d0c3d502

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'daveh86', u'name': u'David Hows', u'email': u'howsdav@gmail.com'} Message: SERVER-18899 - Add beginBackup and endBackup to storage API Branch: master https://github.com/mongodb/mongo/commit/e1d7404eae3a2c33fa4f15105b931f17d0c3d502
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'daveh86', u'name': u'David Hows', u'email': u'howsdav@gmail.com'}

          Message: Revert "SERVER-18899 - Add beginBackup and endBackup to storage API"

          This reverts commit e1d7404eae3a2c33fa4f15105b931f17d0c3d502.
          Branch: master
          https://github.com/mongodb/mongo/commit/3325cd25cd45ca7bdf856f62a740497ba7eedf36

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'daveh86', u'name': u'David Hows', u'email': u'howsdav@gmail.com'} Message: Revert " SERVER-18899 - Add beginBackup and endBackup to storage API" This reverts commit e1d7404eae3a2c33fa4f15105b931f17d0c3d502. Branch: master https://github.com/mongodb/mongo/commit/3325cd25cd45ca7bdf856f62a740497ba7eedf36
          Hide
          david.hows David Hows added a comment -

          Hey Mathias Stearn,

          Would appreciate your input here. As a consequence of making the changes we discussed around returning CommandNotSupported by default, there are a large number of test failures for rocksdb.

          Looking over those failures, they mostly seem to come from places where we are using fsyncLock to block writes, rather than guarantee filesystem consistency (replication tests where we block writes to secondary's are a common example). There are about 10~ test suites which would need to be modified in order to stop these errors.

          Wanted your input on how best to proceed, currently I see the following as options:

          1. Leave the tests broken until we fix the issue in mongo-rocks
          2. Modify all of theses tests to skip the relevant part when fsync returns CommandNotSupported
          Show
          david.hows David Hows added a comment - Hey Mathias Stearn , Would appreciate your input here. As a consequence of making the changes we discussed around returning CommandNotSupported by default, there are a large number of test failures for rocksdb. Looking over those failures, they mostly seem to come from places where we are using fsyncLock to block writes, rather than guarantee filesystem consistency (replication tests where we block writes to secondary's are a common example). There are about 10~ test suites which would need to be modified in order to stop these errors. Wanted your input on how best to proceed, currently I see the following as options: Leave the tests broken until we fix the issue in mongo-rocks Modify all of theses tests to skip the relevant part when fsync returns CommandNotSupported
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'daveh86', u'name': u'David Hows', u'email': u'howsdav@gmail.com'}

          Message: SERVER-18899 - Add beginBackup and endBackup to storage API
          Branch: master
          https://github.com/mongodb/mongo/commit/e5bd1ecd48d78900bafd64022200f94eb7be24c7

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'daveh86', u'name': u'David Hows', u'email': u'howsdav@gmail.com'} Message: SERVER-18899 - Add beginBackup and endBackup to storage API Branch: master https://github.com/mongodb/mongo/commit/e5bd1ecd48d78900bafd64022200f94eb7be24c7
          Hide
          david.hows David Hows added a comment -

          This change adds 2 new calls into the storage API, beginBackup and endBackup. These are required calls now when running the fsync command

          Show
          david.hows David Hows added a comment - This change adds 2 new calls into the storage API, beginBackup and endBackup. These are required calls now when running the fsync command

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              19 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: