Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-25145

During rollback (or w/minvalid invalid) select sync source based on end OpTime

    Details

      Description

      If we use the lastFetchedOptime, which is also the common point found during rollback, it is possible that a sync source is selected which will cause the rollback to be attempted again (after the first says it succeeds), but while in an inconsistent state (with minvalid showing an invalid state, needing to apply before being consistent).

      By using the end of minvalid bounds as a criteria for sync source selection it will not be possible to do another rollback until the first has completed and apply all necessary options to get into a consistent state.

        Issue Links

          Activity

          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

          Message: SERVER-25145 BackgroundSync provides minValid to sync source selection in RECOVERING mode

          (cherry picked from commit fb1cc32e76910334327c0835e3777ee1ddedf2d8)
          Branch: v3.2
          https://github.com/mongodb/mongo/commit/560dc779aff60c78fd28194a1412a944cffe32f5

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'} Message: SERVER-25145 BackgroundSync provides minValid to sync source selection in RECOVERING mode (cherry picked from commit fb1cc32e76910334327c0835e3777ee1ddedf2d8) Branch: v3.2 https://github.com/mongodb/mongo/commit/560dc779aff60c78fd28194a1412a944cffe32f5
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'stbrody', u'name': u'Spencer T Brody', u'email': u'spencer@mongodb.com'}

          Message: SERVER-25145 Add jstest to ensure that we can no longer trigger double-rollback.
          Branch: master
          https://github.com/mongodb/mongo/commit/f5c613f11f170cadd4b698d108b3c7b636913568

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'stbrody', u'name': u'Spencer T Brody', u'email': u'spencer@mongodb.com'} Message: SERVER-25145 Add jstest to ensure that we can no longer trigger double-rollback. Branch: master https://github.com/mongodb/mongo/commit/f5c613f11f170cadd4b698d108b3c7b636913568
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'stbrody', u'name': u'Spencer T Brody', u'email': u'spencer@mongodb.com'}

          Message: SERVER-25145 Add jstest to ensure that we can no longer trigger double-rollback.

          (cherry picked from commit 3716f0ab00f8f2f4e5e85a87dc06c125628fe03e)
          Branch: v3.2
          https://github.com/mongodb/mongo/commit/f3a4d0914fca1ad2fc9a659f4ece42f9dcf0b2c2

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'stbrody', u'name': u'Spencer T Brody', u'email': u'spencer@mongodb.com'} Message: SERVER-25145 Add jstest to ensure that we can no longer trigger double-rollback. (cherry picked from commit 3716f0ab00f8f2f4e5e85a87dc06c125628fe03e) Branch: v3.2 https://github.com/mongodb/mongo/commit/f3a4d0914fca1ad2fc9a659f4ece42f9dcf0b2c2
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'stbrody', u'name': u'Spencer T Brody', u'email': u'spencer@mongodb.com'}

          Message: SERVER-25145 fix lint
          Branch: master
          https://github.com/mongodb/mongo/commit/b85157b4a7ccc68fb05efa092f5b057ac117978f

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'stbrody', u'name': u'Spencer T Brody', u'email': u'spencer@mongodb.com'} Message: SERVER-25145 fix lint Branch: master https://github.com/mongodb/mongo/commit/b85157b4a7ccc68fb05efa092f5b057ac117978f
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'stbrody', u'name': u'Spencer T Brody', u'email': u'spencer@mongodb.com'}

          Message: SERVER-25145 fix lint

          (cherry picked from commit 28b17c04835e4000be52b44e3b96ceaeac95567a)
          Branch: v3.2
          https://github.com/mongodb/mongo/commit/e0e6faf67235d5eb9a758d7b0dd140bd939682c3

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'stbrody', u'name': u'Spencer T Brody', u'email': u'spencer@mongodb.com'} Message: SERVER-25145 fix lint (cherry picked from commit 28b17c04835e4000be52b44e3b96ceaeac95567a) Branch: v3.2 https://github.com/mongodb/mongo/commit/e0e6faf67235d5eb9a758d7b0dd140bd939682c3

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              19 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                  Agile