Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-32208

Remove retrying of OperationFailed in auto_retry_on_network_error.js

    XMLWordPrintable

    Details

      Description

      There used to be a case where a write command swallowed the original error code and replaced it with OperationFailed, but we believe that has been fixed in SERVER-33542. This ticket has been left open to track the work to remove the special case for it here.

      Original Description

      Similarly to SERVER-31730, there are commands that swallow plan executor errors (like InterruptedDueToReplStateChange) and instead return ErrorCodes::OperationFailed. This interferes with mongos retry logic and the retry logic in the jscore and concurrency continuous stepdown suites.

      These are the commands I've seen that definitely have this problem, there may be more though:
      find,
      findAndModify,
      distinct,
      geoNear

      Grepping for "executor error" turns up a few more places where this could be an issue, since it seems like this logic has been copied across a few commands.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              backlog-server-sharding Backlog - Sharding Team
              Reporter:
              jack.mulrow Jack Mulrow
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated: