• Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.3.1
    • Affects Version/s: None
    • Component/s: Build
    • None
    • Fully Compatible
    • Security 2019-11-04

      A recent analysis of lint results showed that the cpplint.py portion of our lint task finds only three classes of issues:

      • Lack of terminal newlines in files
      • Missing copyright headers
      • Use of banned types, an extension that we added to cpplint.py

      What cpplint.py isn't doing is telling us anything interesting about C++. And, now that we have clang-tidy available per SERVER-27984, we have a better C++ linter in play anyway, we find that cpplint.py takes a lot of time in the lint task but tells us little of interest.

      We should write a new tool that can live in the same ecosystem as clang-format and pylint that enforces only the last two items above. It will need to honor NOLINT I expect.

      Later, we should extend clang-tidy to enforce the rules that we want.

            Assignee:
            mark.benvenuto@mongodb.com Mark Benvenuto
            Reporter:
            andrew.morrow@mongodb.com Andrew Morrow (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: