Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-46367

Remove ScanningReplicaSetMonitor specific members from the abstract ReplicaSetMonitor class

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • None
    • 4.7.0
    • None
    • Fully Compatible
    • Sharding 2020-05-18, Sharding 2020-06-01, Sharding 2020-06-15, Sharding 2020-06-29

    Description

      GOAL: separate ScanningReplicaSetMonitor specific members out from the abstract ReplicaSetMonitor class.

      Background: In replica_set_monitor.h, several members are intended for unit-tests only and are only relevant to ScanningReplicaSetMonitor's implementation.

      1. useDeterministicHostSelection
      2. disableRefreshRetries_forTest().
      3. areRefreshRetriesDisabledForTest()

      Why are they in the abstract class right now?
      dbclient_rs_test sets useDeterministicHostSelection and disableRefreshRetriesForTest but is currently expected to be ReplicaSetMonitor version agnostic.

      We need to inspect the use of these test-only members in dbclient_rs_test and determine (1) if the test should remain ReplicaSetMonitor version agnostic and (2) if the members can safely be moved from the ReplicaSetMonitor to the concrete ScanningReplicaSetMonitor class.

      Attachments

        Issue Links

          Activity

            People

              haley.connelly@mongodb.com Haley Connelly
              haley.connelly@mongodb.com Haley Connelly
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: