[SERVER-52974] Checking if destined recipient has changed for resharding creates another full copy of the updated document - MongoDB Jira

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major - P3
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 4.9.0
Component/s: Sharding
Labels:
- PM-234-M2
- PM-234-T-oplog-fetch

Backwards Compatibility:
Fully Compatible
Operating System:
ALL
Sprint:
Sharding 2020-11-30
Linked BF Score:
0

Description

mutablebson::Document::getObject() renders a full copy of the updated document. This can be expensive for larger documents. At minimum we should skip calling it when the collection isn't even sharded like UpdateStage::checkUpdateChangesShardKeyFields() does. Better would be to consolidate some the _doc.getObject() calls that UpdateStage::checkUpdateChangesShardKeyFields(), UpdateStage::wasReshardingKeyUpdated(), and updates which weren't performed in-place all do.

Attachments

Issue Links

is caused by

SERVER-49825 Replicate updates changing value under new shard key pattern as delete + insert in a transaction

Closed

related to

SERVER-54040 Resharding may fail to throw WouldChangeOwningShard despite destined recipient having changed

Closed

SERVER-57666 Convert getDestinedRecipient() in resharding_util to be a class method

Closed

SERVER-58918 Replace getDestinedRecipient() in the code-base with calls into the ReshardingDonorWriteRouter object

Closed

Activity

People

Assignee:: Max Hirschhorn

Reporter:: Max Hirschhorn

Participants:: Githook User, Max Hirschhorn

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: Nov 20 2020 07:08:58 PM UTC

Updated:: Jul 28 2021 03:50:38 PM UTC

Resolved:: Nov 21 2020 03:47:14 AM UTC