Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-57521

FCV change unconditionally closes outgoing connections that have not finished their hello handshake

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1.0, 5.0.2
    • Component/s: None
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Backport Requested:
      v5.0
    • Sprint:
      Sharding 2021-06-28
    • Linked BF Score:
      50

      Description

      Upon changing the FCV value, outgoing connections to servers with a lower binary version are closed. This is done by closing all the connections except those tagged with transport::Session::kKeepOpen.
      However, there exists a race condition between setting the kKeepOpen flag during the hello handshake, and deciding whether to close the connection by looking at the tags.
      As a result, connections that are in the process of being established can be incorrectly dropped during setFCV.

      ConnectionPool::dropConnections is not considering the kPending flag.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              janna.golden Janna Golden
              Reporter:
              jordi.serra-torrens Jordi Serra Torrens
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: