Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-57521

FCV change unconditionally closes outgoing connections that have not finished their hello handshake

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 5.0.2, 5.1.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None
    • Fully Compatible
    • v5.0
    • Sharding 2021-06-28
    • 50

      Upon changing the FCV value, outgoing connections to servers with a lower binary version are closed. This is done by closing all the connections except those tagged with transport::Session::kKeepOpen.
      However, there exists a race condition between setting the kKeepOpen flag during the hello handshake, and deciding whether to close the connection by looking at the tags.
      As a result, connections that are in the process of being established can be incorrectly dropped during setFCV.

      ConnectionPool::dropConnections is not considering the kPending flag.

            Assignee:
            janna.golden@mongodb.com Janna Golden
            Reporter:
            jordi.serra-torrens@mongodb.com Jordi Serra Torrens
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: