Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-57654

Call Pipeline::dispose() if Pipeline::getNext() throws in ReshardingCollectionCloner

    XMLWordPrintableJSON

Details

    • Fully Compatible
    • v5.0
    • Sharding 2021-07-12
    • 1

    Description

      We should add a guard around the call to resharding::data_copy::fillBatchForInsert() to call Pipeline::dispose() if Pipeline::getNext() throws.

      auto guard = makeGuard([&] { pipeline->dispose(opCtx); pipeline.reset() });
      		 
      pipeline->reattachToOperationContext(opCtx);
      		 
      auto doc = pipeline->getNext();
      		 
      pipeline->detachFromOperationContext();
      		 
      guard.dismiss();

      Note that this other call to Pipeline::getNext() doesn't an explicit guard to call Pipeline::dispose() because PipelineDeleter::dismissDisposal() hasn't been called yet.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. SERVER-56437 ReshardingDonorOplogIterator destroys OperationContext with Pipeline still attached on exception

          • Major - P3 - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. SERVER-57653 ReshardingDonorOplogIterator must call Pipeline::dispose() if Pipeline::getNext() throws

          • Major - P3 - Major loss of function.
          • Closed

          Activity

            People

              luis.osta@mongodb.com Luis Osta (Inactive)
              max.hirschhorn@mongodb.com Max Hirschhorn
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: