Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-65776

Improve version comparison in linter runner

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Major - P3 Major - P3
    • None
    • None
    • None
    • None
    • Correctness
    • OnDeck

    Description

      Currently we check that given linter version is not lower than the required version. We are doing that with pkg_resources.parse_version():
      https://github.com/mongodb/mongo/blob/8ad97ab6e15eb185438f37b2e9a2e3d9724f9493/buildscripts/linter/runner.py#L44
      The pkg_resources.parse_version() returns either Version or LegacyVersion object, which could be incomparable with each other. We should make sure that it works correctly.

      Attachments

        Activity

          People

            devprod-correctness-team@mongodb.com [DO NOT ASSIGN] Backlog - DevProd Correctness
            mikhail.shchatko@mongodb.com Mikhail Shchatko
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: