Rename isEnabledAndIgnoreFCV() to be isEnabledAndIgnoreFCVUnsafe() and audit usages

XMLWordPrintableJSON

    • Replication
    • Fully Compatible
    • Repl 2023-04-03, Repl 2023-04-17
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      We should rename isEnabledAndIgnoreFCV() to be isEnabledAndIgnoreFCVUnsafe() and require any usages to have a comment in some number of lines preceding it. This is because we want to avoid using isEnabledAndIgnoreFCV() in general

      For places where commands and aggregation states/expressions are registered that use isEnabledAndIgnoreFCV, we should add a function isEnabledAndIgnoreFCVAtStartup() which has the same behavior as isEnabledAndIgnoreFCVUnsafe() but won’t require a comment.

      We should also add better documentation about when to use isEnabled vs isEnabledAndIgnoreFCVAtStartup

              Assignee:
              Jiawei Yang
              Reporter:
              Huayu Ouyang
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: