Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-75396

Confirm FeatureFlag::isEnabledAndIgnoreFCVUnsafe() usage for security

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 7.1.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Server Security
    • Fully Compatible
    • Security 2023-04-17, Security 2023-05-01

      We formalized the usage of FeatureFlag::isEnabledAndIgnoreFCV() in https://jira.mongodb.org/browse/SERVER-66587. Now every usage of FeatureFlag::isEnabledAndIgnoreFCV() is changed to FeatureFlag::isEnabledAndIgnoreFCVUnsafe() and ask the engineer to add a comment describing why you have to ignore FCV here.

      Overall, we expect places that are using FeatureFlag::isEnabledAndIgnoreFCVUnsafe() now to be:

      • isEnabledAndIgnoreFCVUnsafeAtStartup() if this feature flag check is before FCV initialization.
      • Stay isEnabledAndIgnoreFCVUnsafe() if you have a reason, and update your reason in the comment line starting with (Ignore FCV check):
      • Change to isEnabled(FCV).

      You can also search for TODO(SERVER-75396) for all places need to revisit

            Assignee:
            sara.golemon@mongodb.com Sara Golemon
            Reporter:
            jiawei.yang@mongodb.com Jiawei Yang
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: