Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-66719

dbCheck FCV lock upgrade causes deadlock with setFCV

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • None
    • 5.3.2, 6.0.0-rc8, 6.1.0-rc0
    • None
    • None
    • Fully Compatible
    • ALL
    • v6.0
    • Execution Team 2022-05-30
    • 169

    Description

      dbCheck, which initially only holds IS locks in the global hierarchy (except the FCV lock), upgrades its locks to IX when writing to the oplog.

      This causes a deadlock with a concurrent setFCV command and a DDL operation, in this example, dropCollection:

      • dbCheck holds all IS locks in the global hierarchy including the IS collection lock, but it doesn't hold the FCV lock, which we only take in exclusive (IX,X) lock modes.
      • dropCollection holds an IX FCV lock. It waits on an X collection lock behind dbCheck
      • setFCV waits on an S FCV lock behind dropCollection
      • dbCheck tries to take an IX FCV lock behind the setFCV

      We support lock upgrades in the lock manager. If the dbCheck operation had taken an IS FCV lock, it would have skipped the queue ahead of the waiting setFCV command, and this deadlock did not happen. This is described in this comment.

      This ticket will address the deadlock concern by not upgrading the global locks in dbCheck, since this is generally dangerous.

      Attachments

        Issue Links

          Activity

            People

              gregory.noma@mongodb.com Gregory Noma
              louis.williams@mongodb.com Louis Williams
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: