enable performance-unnecessary-value-param clang-tidy check

XMLWordPrintableJSON

    • Type: New Feature
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Server Programmability
    • 2024-12-24
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Add clang-tidy check for the following

      https://releases.llvm.org/12.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/performance-unnecessary-value-param.html

       

      You should make the change in to add this check in ".clang-tidy.in", rerun the command to generate compile_commands.json "python3 ./buildscripts/scons.py --build-profile=compiledb compiledb", the run clang-tidy "python3 buildscripts/clang_tidy.py" and fix the areas where it shows problems. If this turns out to be a significant amount of changes (>50) then lets sync and see if this is worth doing. We might want to punt depending on how significant this is.

              Assignee:
              Unassigned
              Reporter:
              Alex Neben
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Created:
                Updated: