Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-77896

enable performance-unnecessary-value-param clang-tidy check

    • Type: Icon: New Feature New Feature
    • Resolution: Won't Do
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Build

      Add clang-tidy check for the following

      https://releases.llvm.org/12.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/performance-unnecessary-value-param.html

       

      You should make the change in to add this check in ".clang-tidy.in", rerun the command to generate compile_commands.json "python3 ./buildscripts/scons.py --build-profile=compiledb compiledb", the run clang-tidy "python3 buildscripts/clang_tidy.py" and fix the areas where it shows problems. If this turns out to be a significant amount of changes (>50) then lets sync and see if this is worth doing. We might want to punt depending on how significant this is.

            Assignee:
            juan.gu@mongodb.com Juan Gu
            Reporter:
            alex.neben@mongodb.com Alex Neben
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: