-
Type: Bug
-
Resolution: Unresolved
-
Priority: Major - P3
-
None
-
Affects Version/s: None
-
Component/s: None
-
None
-
ALL
-
2024-12-24
After enabling the performance-unnecessary-value-param check.
here is the branch comparison after I applied the generated fixes with our apply_clang_tidy_fixes.py script
Showing 1,460 changed files with 6,910 additions and 6,454 deletions.
However, I noticed that some of the changes are not correct. For example, the changes in dependency_graph.cpp. const and & have been inserted in the wrong place.
+ for (auto& otherNode : dependeconst nts) + _nodes[othe&rNode].prerequisites.insert(name)const ; + newNode.payload = &std::move(payload);
It seems there might be some bugs either in our wrapper script or in clang_tidy.py. I am 90% sure the problem is in the _combine_errors function in clang_tidy.py.
- is depended on by
-
SERVER-77896 enable performance-unnecessary-value-param clang-tidy check
- Backlog