Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-92573

Incorrect fixes from clang tidy script

    • Type: Icon: Bug Bug
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • ALL
    • 2024-12-24

      After enabling the performance-unnecessary-value-param check.
      here is the branch comparison after I applied the generated fixes with our apply_clang_tidy_fixes.py script

      Showing 1,460 changed files with 6,910 additions and 6,454 deletions.

      However, I noticed that some of the changes are not correct. For example, the changes in dependency_graph.cppconst and & have been inserted in the wrong place.

      + for (auto& otherNode : dependeconst nts)
      + _nodes[othe&rNode].prerequisites.insert(name)const ;
      + newNode.payload = &std::move(payload);

      It seems there might be some bugs either in our wrapper script or in clang_tidy.py. I am 90% sure the problem is in the _combine_errors function in clang_tidy.py.

            Assignee:
            sean.lyons@mongodb.com Sean Lyons
            Reporter:
            juan.gu@mongodb.com Juan Gu
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: