Uploaded image for project: 'VS Code Extension'
  1. VS Code Extension
  2. VSCODE-184

Update keytar usage to only store 1 credential

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open
    • Priority: Major - P3
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Story Points:
      5
    • Sprint:
      Iteration Orange

      Description

      Recently vscode did a release which moved their credential storing native node module keytar to a new process: https://github.com/microsoft/vscode/issues/108342#issuecomment-706340396 
      https://code.visualstudio.com/updates/v1_50#_macos-keychain-access-moved-to-a-different-process

      This results in our extension asking for keychain permissions for each stored connection. While this is something that needs to happen when the process accessing the keychain changes, we can change our usage of the credential store to store one key which is used to access or decrypt all of the connections. This will make it so that if something similar happens in the future, the usage of keytar changes, we can ask just once for access to the keychain instead of something that really hurts user experience.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              rhys.howell Rhys Howell
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated: