-
Type:
Technical Debt
-
Resolution: Unresolved
-
Priority:
Trivial - P5
-
None
-
Affects Version/s: None
-
Component/s: Filesystem API, Live Restore
-
Storage Engines
-
3
-
StorEng - Defined Pipeline
This is more of a nit than a defect. Currently WT_LIVE_RESTORE_FILE_HANDLE is defined as
struct __wt_live_restore_file_handle {
WT_FILE_HANDLE iface;
WT_FILE_HANDLE *source;
struct {
WT_FILE_HANDLE *fh;
bool complete;
WT_LIVE_RESTORE_FS *back_pointer;
WT_LIVE_RESTORE_HOLE_NODE *hole_list_head;
} destination;
WT_FS_OPEN_FILE_TYPE file_type;
};
where metadata is located on the destination's file handle. This would look cleaner as:
struct __wt_live_restore_file_handle {
WT_FILE_HANDLE iface;
// Backing files
WT_FILE_HANDLE *source;
WT_FILE_HANDLE *destination;
// Handle metadata
bool complete;
WT_LIVE_RESTORE_FS *back_pointer;
WT_LIVE_RESTORE_HOLE_NODE *hole_list_head;
WT_FS_OPEN_FILE_TYPE file_type;
};