Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-195

__wt_cache_page_read simplification

    • Type: Icon: Task Task
    • Resolution: Done
    • WT1.2
    • Affects Version/s: None
    • Component/s: None

      *wt_cache_page_read() is only called from *wt_cache_read(), based on a value returned from __wt_page_inmem().

      Why not change *wt_page_inmem() to call *wt_cache_page_read() directly, and remove its inmem_size argument?

      I think it's simpler code and trivially more correct (we'll include the root page in our cache memory calculations).

      My only concern is that we depend in some way on not including the root page in our memory calculations, or salvage pages (salvage also calls __wt_page_inmem()). It looks safe, but I'm not 100% sure.

            Assignee:
            michael.cahill@mongodb.com Michael Cahill (Inactive)
            Reporter:
            keith.bostic@mongodb.com Keith Bostic (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: