Uploaded image for project: 'WiredTiger'
  1. WiredTiger
  2. WT-2525

in-memory configurations: miscellaneous cleanups

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor - P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: WT2.9.0
    • Labels:
      None

      Description

      Coverity and other cleanups after WT-2330 merge.

        Issue Links

          Activity

          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith@wiredtiger.com'}

          Message: WT-2525: in-memory configurations: miscellaneous cleanups

          Coverity 1353723: don't provide a special-case locking path for
          in-memory configuration file size queries. It's complicated and
          invites future bugs, and there's no performance reason we need
          the magic.
          Branch: mongodb-3.2
          https://github.com/wiredtiger/wiredtiger/commit/39edc9f66220bab5a8c5e8f0ae6f26979605cd39

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith@wiredtiger.com'} Message: WT-2525 : in-memory configurations: miscellaneous cleanups Coverity 1353723: don't provide a special-case locking path for in-memory configuration file size queries. It's complicated and invites future bugs, and there's no performance reason we need the magic. Branch: mongodb-3.2 https://github.com/wiredtiger/wiredtiger/commit/39edc9f66220bab5a8c5e8f0ae6f26979605cd39
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith@wiredtiger.com'}

          Message: WT-2525: in-memory configurations: miscellaneous cleanups

          Coverity 1353725, 1353726: __wt_metadata_search() and __wt_turtle_read()
          could return errors after allocating memory, which was then leaked by
          their callers.
          Branch: mongodb-3.2
          https://github.com/wiredtiger/wiredtiger/commit/d2f5a34263ee812615d76172abbcc4d60f230ff4

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith@wiredtiger.com'} Message: WT-2525 : in-memory configurations: miscellaneous cleanups Coverity 1353725, 1353726: __wt_metadata_search() and __wt_turtle_read() could return errors after allocating memory, which was then leaked by their callers. Branch: mongodb-3.2 https://github.com/wiredtiger/wiredtiger/commit/d2f5a34263ee812615d76172abbcc4d60f230ff4
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith@wiredtiger.com'}

          Message: WT-2525: in-memory configurations: miscellaneous cleanups

          Coverity 1353727: va_copy() missing the va_end() call.
          Branch: mongodb-3.2
          https://github.com/wiredtiger/wiredtiger/commit/ca04aafcd12b00e8821edea09b635de2c1efadb9

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'keithbostic', u'name': u'Keith Bostic', u'email': u'keith@wiredtiger.com'} Message: WT-2525 : in-memory configurations: miscellaneous cleanups Coverity 1353727: va_copy() missing the va_end() call. Branch: mongodb-3.2 https://github.com/wiredtiger/wiredtiger/commit/ca04aafcd12b00e8821edea09b635de2c1efadb9
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'sueloverso', u'name': u'sueloverso', u'email': u'sue@mongodb.com'}

          Message: Merge pull request #2621 from wiredtiger/wt-2525

          WT-2525: in-memory configurations: miscellaneous cleanups
          Branch: mongodb-3.2
          https://github.com/wiredtiger/wiredtiger/commit/4810db116772f6173f746d1439811d67bd304c6b

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'sueloverso', u'name': u'sueloverso', u'email': u'sue@mongodb.com'} Message: Merge pull request #2621 from wiredtiger/wt-2525 WT-2525 : in-memory configurations: miscellaneous cleanups Branch: mongodb-3.2 https://github.com/wiredtiger/wiredtiger/commit/4810db116772f6173f746d1439811d67bd304c6b
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'name': u'Ramon Fernandez', u'email': u'ramon@mongodb.com'}

          Message: Import wiredtiger-wiredtiger-2.8.0-201-g7ea2631.tar.gz from wiredtiger branch mongodb-3.2

          ref: 43e885a..7ea2631

          SERVER-23504 Coverity analysis defect 98177: Resource leak
          SERVER-23526 Replication relies on storage engines reporting a non-zero size for correctness
          SERVER-23588 mongod with WiredTiger won't start on Windows when built with --dbg=on --opt=off
          SERVER-23682 WiredTiger changes for MongoDB 3.2.6
          WT-2330 in-memory configurations should not create on-disk collection files
          WT-2507 Add upgrading documentation in preparation for 2.8 release.
          WT-2512 wtperf: MSVC complains about float conversion in throttle code
          WT-2513 conversion from 'int64_t' to 'uint32_t'
          WT-2517 wtperf uses setvbuf in a way that isn't supported on Windows
          WT-2522 Incorrect format code in message
          WT-2525 in-memory configurations: miscellaneous cleanups
          WT-2527 OS X compile error, missing POSIX_FADV_WILLNEED #define
          WT-2528 style error in WiredTiger build
          WT-2529 The readonly test case is crashing with a stack overflow
          WT-2531 in-memory tables are allocating unnecessary memory
          WT-2532 WT_STREAM_APPEND and WT_STREAM_LINE_BUFFER flag overlap
          WT-2533 Ensure that in-memory tables don't report a zero size
          WT-2534 Invalid transaction snapshots on PowerPC
          Branch: v3.2
          https://github.com/mongodb/mongo/commit/7ee4e4e493c3785fea489ee3508ca18526709c16

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'name': u'Ramon Fernandez', u'email': u'ramon@mongodb.com'} Message: Import wiredtiger-wiredtiger-2.8.0-201-g7ea2631.tar.gz from wiredtiger branch mongodb-3.2 ref: 43e885a..7ea2631 SERVER-23504 Coverity analysis defect 98177: Resource leak SERVER-23526 Replication relies on storage engines reporting a non-zero size for correctness SERVER-23588 mongod with WiredTiger won't start on Windows when built with --dbg=on --opt=off SERVER-23682 WiredTiger changes for MongoDB 3.2.6 WT-2330 in-memory configurations should not create on-disk collection files WT-2507 Add upgrading documentation in preparation for 2.8 release. WT-2512 wtperf: MSVC complains about float conversion in throttle code WT-2513 conversion from 'int64_t' to 'uint32_t' WT-2517 wtperf uses setvbuf in a way that isn't supported on Windows WT-2522 Incorrect format code in message WT-2525 in-memory configurations: miscellaneous cleanups WT-2527 OS X compile error, missing POSIX_FADV_WILLNEED #define WT-2528 style error in WiredTiger build WT-2529 The readonly test case is crashing with a stack overflow WT-2531 in-memory tables are allocating unnecessary memory WT-2532 WT_STREAM_APPEND and WT_STREAM_LINE_BUFFER flag overlap WT-2533 Ensure that in-memory tables don't report a zero size WT-2534 Invalid transaction snapshots on PowerPC Branch: v3.2 https://github.com/mongodb/mongo/commit/7ee4e4e493c3785fea489ee3508ca18526709c16

            People

            • Assignee:
              keith.bostic Keith Bostic
              Reporter:
              keith.bostic Keith Bostic
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: