[WT-283] Add a way to change persistent object settings - MongoDB

Details

Type: Task
Status: Resolved
Priority: Major - P3
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 3.2.12, WT2.9.1, 3.5.2, 3.4.2
Labels:

# Replies:
12
Last comment by Customer:
true
Sprint:
Storage 2016-12-12, Storage 2017-01-23
External issue ID:
https://github.com/wiredtiger/wiredtiger/issues/283

Description

Sticking with SQL naming, this method should be called "alter". That is:

int WT_SESSION::alter(WT_SESSION *session, const char *uri, const char *config)

The supported configuration strings should be a subset of those permitted by WT_SESSION::create.

Issue Links

is duplicated by

WT-2681 Add ability to change configuration options on tables

Resolved

Activity

Comments

Ascending order - Click to sort in descending order

Hide

Permalink

Michael Cahill added a comment - Jun 03 2016 06:12:25 AM +00:00

When applied to a table: URI, this method must apply the new configuration to the primary colgroup: and file:/lsm: objects (as WT_SESSION::create does). This method must first get exclusive access (as per WT_SESSION::salvage

The basic approach should be to create a config stack with (defaults, existing config, new config), then call __wt_config_collapse, which will generate a potential new metadata value. The defaults should be the permitted values for the metadata as generated by dist/api_config.py, stored in src/config/config_def.c. If there is no change, we're done for this data source.

The new value must be validated (unless WT_SESSION::alter can guarantee that any changes it applies will be valid) and inserted into the metadata.

Show

Michael Cahill added a comment - Jun 03 2016 06:12:25 AM +00:00 When applied to a table: URI, this method must apply the new configuration to the primary colgroup: and file: / lsm: objects (as WT_SESSION::create does). This method must first get exclusive access (as per WT_SESSION::salvage The basic approach should be to create a config stack with (defaults, existing config, new config), then call __wt_config_collapse , which will generate a potential new metadata value. The defaults should be the permitted values for the metadata as generated by dist/api_config.py , stored in src/config/config_def.c . If there is no change, we're done for this data source. The new value must be validated (unless WT_SESSION::alter can guarantee that any changes it applies will be valid) and inserted into the metadata.

6 older comments

Hide

Permalink

Githook User added a comment - Jan 06 2017 01:24:39 AM +00:00

Author:

{u'username': u'sueloverso', u'name': u'sueloverso', u'email': u'sue@mongodb.com'}

Message: ~~WT-283~~ Add WT_SESSION::alter method (#3177)

~~WT-283~~ Add WT_SESSION:alter method

Add new method to ex_all.c

Typo

Add testing and fixes for LSM, column groups and indexes for alter.

Fix WITH_*_LOCK macro usage.

Whitespace

Change table alter to not walk down into column groups and indexes.

Whitespace

Use base file meta config and compare strings.

Add skip stat

Add alter support to wt command.

Add util_alter.c to SConstruct

Fix subsection in doc.

Add alter thread to test/format

Swap the value we send into alter in test/format.

Add data-source alter support

Only alter access pattern hint in test/format.

Make LSM alter not exclusive.

Whitespace

Use access_pattern_hint in example.

Include base lsm metadata configuration.

Fix text/comment.

Minor changes from review comments.

Unused variable warning.
Branch: mongodb-3.4
https://github.com/wiredtiger/wiredtiger/commit/e8d8fd81109554f7ae845b92c716ed54364b433d

Show

Githook User added a comment - Jan 06 2017 01:24:39 AM +00:00 Author: {u'username': u'sueloverso', u'name': u'sueloverso', u'email': u'sue@mongodb.com'} Message: WT-283 Add WT_SESSION::alter method (#3177) WT-283 Add WT_SESSION:alter method Add new method to ex_all.c Typo Add testing and fixes for LSM, column groups and indexes for alter. Fix WITH_*_LOCK macro usage. Whitespace Change table alter to not walk down into column groups and indexes. Whitespace Use base file meta config and compare strings. Add skip stat Add alter support to wt command. Add util_alter.c to SConstruct Fix subsection in doc. Add alter thread to test/format Swap the value we send into alter in test/format. Add data-source alter support Only alter access pattern hint in test/format. Make LSM alter not exclusive. Whitespace Use access_pattern_hint in example. Include base lsm metadata configuration. Fix text/comment. Minor changes from review comments. Unused variable warning. Branch: mongodb-3.4 https://github.com/wiredtiger/wiredtiger/commit/e8d8fd81109554f7ae845b92c716ed54364b433d

Hide

Permalink

Githook User added a comment - Jan 06 2017 01:24:56 AM +00:00

Author:

{u'username': u'sueloverso', u'name': u'sueloverso', u'email': u'sue@mongodb.com'}

Message: ~~WT-283~~ Add WT_SESSION::alter method (#3177)

~~WT-283~~ Add WT_SESSION:alter method

Add new method to ex_all.c

Typo

Add testing and fixes for LSM, column groups and indexes for alter.

Fix WITH_*_LOCK macro usage.

Whitespace

Change table alter to not walk down into column groups and indexes.

Whitespace

Use base file meta config and compare strings.

Add skip stat

Add alter support to wt command.

Add util_alter.c to SConstruct

Fix subsection in doc.

Add alter thread to test/format

Swap the value we send into alter in test/format.

Add data-source alter support

Only alter access pattern hint in test/format.

Make LSM alter not exclusive.

Whitespace

Use access_pattern_hint in example.

Include base lsm metadata configuration.

Fix text/comment.

Minor changes from review comments.

Unused variable warning.
Branch: mongodb-3.2
https://github.com/wiredtiger/wiredtiger/commit/e8d8fd81109554f7ae845b92c716ed54364b433d

Show

Githook User added a comment - Jan 06 2017 01:24:56 AM +00:00 Author: {u'username': u'sueloverso', u'name': u'sueloverso', u'email': u'sue@mongodb.com'} Message: WT-283 Add WT_SESSION::alter method (#3177) WT-283 Add WT_SESSION:alter method Add new method to ex_all.c Typo Add testing and fixes for LSM, column groups and indexes for alter. Fix WITH_*_LOCK macro usage. Whitespace Change table alter to not walk down into column groups and indexes. Whitespace Use base file meta config and compare strings. Add skip stat Add alter support to wt command. Add util_alter.c to SConstruct Fix subsection in doc. Add alter thread to test/format Swap the value we send into alter in test/format. Add data-source alter support Only alter access pattern hint in test/format. Make LSM alter not exclusive. Whitespace Use access_pattern_hint in example. Include base lsm metadata configuration. Fix text/comment. Minor changes from review comments. Unused variable warning. Branch: mongodb-3.2 https://github.com/wiredtiger/wiredtiger/commit/e8d8fd81109554f7ae845b92c716ed54364b433d

Hide

Permalink

Githook User added a comment - Jan 06 2017 01:24:57 AM +00:00

Author:

{u'username': u'sueloverso', u'name': u'sueloverso', u'email': u'sue@mongodb.com'}

Message: ~~WT-283~~ Add WT_SESSION::alter method (#3177)

~~WT-283~~ Add WT_SESSION:alter method

Add new method to ex_all.c

Typo

Add testing and fixes for LSM, column groups and indexes for alter.

Fix WITH_*_LOCK macro usage.

Whitespace

Change table alter to not walk down into column groups and indexes.

Whitespace

Use base file meta config and compare strings.

Add skip stat

Add alter support to wt command.

Add util_alter.c to SConstruct

Fix subsection in doc.

Add alter thread to test/format

Swap the value we send into alter in test/format.

Add data-source alter support

Only alter access pattern hint in test/format.

Make LSM alter not exclusive.

Whitespace

Use access_pattern_hint in example.

Include base lsm metadata configuration.

Fix text/comment.

Minor changes from review comments.

Unused variable warning.
Branch: mongodb-3.2
https://github.com/wiredtiger/wiredtiger/commit/e8d8fd81109554f7ae845b92c716ed54364b433d

Show

Githook User added a comment - Jan 06 2017 01:24:57 AM +00:00 Author: {u'username': u'sueloverso', u'name': u'sueloverso', u'email': u'sue@mongodb.com'} Message: WT-283 Add WT_SESSION::alter method (#3177) WT-283 Add WT_SESSION:alter method Add new method to ex_all.c Typo Add testing and fixes for LSM, column groups and indexes for alter. Fix WITH_*_LOCK macro usage. Whitespace Change table alter to not walk down into column groups and indexes. Whitespace Use base file meta config and compare strings. Add skip stat Add alter support to wt command. Add util_alter.c to SConstruct Fix subsection in doc. Add alter thread to test/format Swap the value we send into alter in test/format. Add data-source alter support Only alter access pattern hint in test/format. Make LSM alter not exclusive. Whitespace Use access_pattern_hint in example. Include base lsm metadata configuration. Fix text/comment. Minor changes from review comments. Unused variable warning. Branch: mongodb-3.2 https://github.com/wiredtiger/wiredtiger/commit/e8d8fd81109554f7ae845b92c716ed54364b433d

Hide

Permalink

Githook User added a comment - Jan 06 2017 03:35:20 AM +00:00

Author:

{u'username': u'daveh86', u'name': u'David Hows', u'email': u'howsdav@gmail.com'}

Message: Import wiredtiger: d48181f6f4db08761ed7b80b0332908b272ad0d0 from branch mongodb-3.2

ref: 040e3d6f76..d48181f6f4
for: 3.2.12

~~SERVER-26545~~ Remove fixed-size limitation on WiredTiger hazard pointers
~~WT-2336~~ Add a test validating schema operations via file system call monitoring
~~WT-2402~~ Misaligned structure accesses lead to undefined behavior
~~WT-2670~~ Inefficient I/O when read full DB (poor readahead)
~~WT-283~~ Add a way to change persistent object settings
~~WT-2960~~ Inserting multi-megabyte values can cause pathological lookaside usage
~~WT-2969~~ Possible snapshot corruption during compaction
~~WT-3014~~ Add GCC/clang support for ELF symbol visibility.
~~WT-3021~~ Fixes needed for Java log cursor example, Java raw mode cursors, log cursors in raw mode
~~WT-3025~~ fix error path in log_force_sync
~~WT-3028~~ Workloads with all dirty pages could trigger diagnostic stuck check
~~WT-3030~~ Test failure indicating invalid key order during traversal
~~WT-3034~~ Add support for single-writer named snapshots.
~~WT-3037~~ Fix some outdated comments in logging
~~WT-3048~~ WiredTiger maximum size warning uses the wrong format.
~~WT-3051~~ Remove external __wt_hex symbol.
~~WT-3052~~ Improve search if an index hint is wrong
~~WT-3053~~ Review Python and Java calls to internal WiredTiger functions
~~WT-3054~~ Java PackTest, PackTest03 do not compile
~~WT-3055~~ Java AsyncTest faults
~~WT-3056~~ For cursors with projections, keys should be allowed
~~WT-3057~~ WiredTiger hazard pointers should use the WT_REF, not the WT_PAGE.
~~WT-3061~~ syscall test runs with checkpoint_sync=false and doesn't acknowledge pwrite64
~~WT-3064~~ minor tree cleanups: .gitignore, NEWS misspelling
~~WT-3066~~ lint
~~WT-3068~~ Copy wtperf artifacts when running Jenkins tests
~~WT-3069~~ Fix build failures in LevelDB APIs
~~WT-3070~~ Fix search_near() for index cursor
~~WT-3071~~ Java: fix build with -Werror=sign-conversion
~~WT-3075~~ Document and enforce that WiredTiger now depends on Python 2.7
~~WT-3078~~ Fix a hang in the reconfiguration test.
~~WT-3084~~ Fix Coverity resource leak complaint.
Branch: v3.2
https://github.com/mongodb/mongo/commit/52b68fa86ea43e909ad42c901d0579bced6b205f

Show

Githook User added a comment - Jan 06 2017 03:35:20 AM +00:00 Author: {u'username': u'daveh86', u'name': u'David Hows', u'email': u'howsdav@gmail.com'} Message: Import wiredtiger: d48181f6f4db08761ed7b80b0332908b272ad0d0 from branch mongodb-3.2 ref: 040e3d6f76..d48181f6f4 for: 3.2.12 SERVER-26545 Remove fixed-size limitation on WiredTiger hazard pointers WT-2336 Add a test validating schema operations via file system call monitoring WT-2402 Misaligned structure accesses lead to undefined behavior WT-2670 Inefficient I/O when read full DB (poor readahead) WT-283 Add a way to change persistent object settings WT-2960 Inserting multi-megabyte values can cause pathological lookaside usage WT-2969 Possible snapshot corruption during compaction WT-3014 Add GCC/clang support for ELF symbol visibility. WT-3021 Fixes needed for Java log cursor example, Java raw mode cursors, log cursors in raw mode WT-3025 fix error path in log_force_sync WT-3028 Workloads with all dirty pages could trigger diagnostic stuck check WT-3030 Test failure indicating invalid key order during traversal WT-3034 Add support for single-writer named snapshots. WT-3037 Fix some outdated comments in logging WT-3048 WiredTiger maximum size warning uses the wrong format. WT-3051 Remove external __wt_hex symbol. WT-3052 Improve search if an index hint is wrong WT-3053 Review Python and Java calls to internal WiredTiger functions WT-3054 Java PackTest, PackTest03 do not compile WT-3055 Java AsyncTest faults WT-3056 For cursors with projections, keys should be allowed WT-3057 WiredTiger hazard pointers should use the WT_REF, not the WT_PAGE. WT-3061 syscall test runs with checkpoint_sync=false and doesn't acknowledge pwrite64 WT-3064 minor tree cleanups: .gitignore, NEWS misspelling WT-3066 lint WT-3068 Copy wtperf artifacts when running Jenkins tests WT-3069 Fix build failures in LevelDB APIs WT-3070 Fix search_near() for index cursor WT-3071 Java: fix build with -Werror=sign-conversion WT-3075 Document and enforce that WiredTiger now depends on Python 2.7 WT-3078 Fix a hang in the reconfiguration test. WT-3084 Fix Coverity resource leak complaint. Branch: v3.2 https://github.com/mongodb/mongo/commit/52b68fa86ea43e909ad42c901d0579bced6b205f

Hide

Permalink

Githook User added a comment - Jan 06 2017 04:23:41 AM +00:00

Author:

{u'username': u'daveh86', u'name': u'David Hows', u'email': u'howsdav@gmail.com'}

Message: Import wiredtiger: 8d2324943364286056ae399043f70b8a937de312 from branch mongodb-3.4

ref: ca6eee06ff..8d23249433
for: 3.4.2

~~SERVER-26545~~ Remove fixed-size limitation on WiredTiger hazard pointers
~~WT-2336~~ Add a test validating schema operations via file system call monitoring
~~WT-2402~~ Misaligned structure accesses lead to undefined behavior
~~WT-2670~~ Inefficient I/O when read full DB (poor readahead)
~~WT-283~~ Add a way to change persistent object settings
~~WT-2960~~ Inserting multi-megabyte values can cause pathological lookaside usage
~~WT-2969~~ Possible snapshot corruption during compaction
~~WT-3014~~ Add GCC/clang support for ELF symbol visibility.
~~WT-3021~~ Fixes needed for Java log cursor example, Java raw mode cursors, log cursors in raw mode
~~WT-3025~~ fix error path in log_force_sync
~~WT-3028~~ Workloads with all dirty pages could trigger diagnostic stuck check
~~WT-3030~~ Test failure indicating invalid key order during traversal
~~WT-3034~~ Add support for single-writer named snapshots.
~~WT-3037~~ Fix some outdated comments in logging
~~WT-3048~~ WiredTiger maximum size warning uses the wrong format.
~~WT-3051~~ Remove external __wt_hex symbol.
~~WT-3052~~ Improve search if an index hint is wrong
~~WT-3053~~ Review Python and Java calls to internal WiredTiger functions
~~WT-3054~~ Java PackTest, PackTest03 do not compile
~~WT-3055~~ Java AsyncTest faults
~~WT-3056~~ For cursors with projections, keys should be allowed
~~WT-3057~~ WiredTiger hazard pointers should use the WT_REF, not the WT_PAGE.
~~WT-3061~~ syscall test runs with checkpoint_sync=false and doesn't acknowledge pwrite64
~~WT-3064~~ minor tree cleanups: .gitignore, NEWS misspelling
~~WT-3066~~ lint
~~WT-3068~~ Copy wtperf artifacts when running Jenkins tests
~~WT-3069~~ Fix build failures in LevelDB APIs
~~WT-3070~~ Fix search_near() for index cursor
~~WT-3071~~ Java: fix build with -Werror=sign-conversion
~~WT-3075~~ Document and enforce that WiredTiger now depends on Python 2.7
~~WT-3078~~ Fix a hang in the reconfiguration test.
~~WT-3084~~ Fix Coverity resource leak complaint.
Branch: v3.4
https://github.com/mongodb/mongo/commit/d2c64ac8c526b70eadeb859ec41370a5f03a64aa

Show

Githook User added a comment - Jan 06 2017 04:23:41 AM +00:00 Author: {u'username': u'daveh86', u'name': u'David Hows', u'email': u'howsdav@gmail.com'} Message: Import wiredtiger: 8d2324943364286056ae399043f70b8a937de312 from branch mongodb-3.4 ref: ca6eee06ff..8d23249433 for: 3.4.2 SERVER-26545 Remove fixed-size limitation on WiredTiger hazard pointers WT-2336 Add a test validating schema operations via file system call monitoring WT-2402 Misaligned structure accesses lead to undefined behavior WT-2670 Inefficient I/O when read full DB (poor readahead) WT-283 Add a way to change persistent object settings WT-2960 Inserting multi-megabyte values can cause pathological lookaside usage WT-2969 Possible snapshot corruption during compaction WT-3014 Add GCC/clang support for ELF symbol visibility. WT-3021 Fixes needed for Java log cursor example, Java raw mode cursors, log cursors in raw mode WT-3025 fix error path in log_force_sync WT-3028 Workloads with all dirty pages could trigger diagnostic stuck check WT-3030 Test failure indicating invalid key order during traversal WT-3034 Add support for single-writer named snapshots. WT-3037 Fix some outdated comments in logging WT-3048 WiredTiger maximum size warning uses the wrong format. WT-3051 Remove external __wt_hex symbol. WT-3052 Improve search if an index hint is wrong WT-3053 Review Python and Java calls to internal WiredTiger functions WT-3054 Java PackTest, PackTest03 do not compile WT-3055 Java AsyncTest faults WT-3056 For cursors with projections, keys should be allowed WT-3057 WiredTiger hazard pointers should use the WT_REF, not the WT_PAGE. WT-3061 syscall test runs with checkpoint_sync=false and doesn't acknowledge pwrite64 WT-3064 minor tree cleanups: .gitignore, NEWS misspelling WT-3066 lint WT-3068 Copy wtperf artifacts when running Jenkins tests WT-3069 Fix build failures in LevelDB APIs WT-3070 Fix search_near() for index cursor WT-3071 Java: fix build with -Werror=sign-conversion WT-3075 Document and enforce that WiredTiger now depends on Python 2.7 WT-3078 Fix a hang in the reconfiguration test. WT-3084 Fix Coverity resource leak complaint. Branch: v3.4 https://github.com/mongodb/mongo/commit/d2c64ac8c526b70eadeb859ec41370a5f03a64aa

People

Assignee:

Sue LoVerso

Reporter:

Michael Cahill

Participants:

Githook User, Michael Cahill, Sue LoVerso

Last commenter:

Githook User

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

Aug 03 2012 03:27:32 AM +00:00

Updated:

Jan 06 2017 04:23:41 AM +00:00

Resolved:

Dec 15 2016 06:12:04 PM +00:00

Days since reply:

24 weeks, 5 days ago

Date of 1st Reply:

11/Oct/16 4:13 PM

Agile

Completed Sprints:

Storage 2016-12-12 ended 08/Dec/16
Storage 2017-01-23 ended 19/Jan/17
View on Board