Uploaded image for project: 'C++ Driver'
  1. C++ Driver
  2. CXX-245

Atomics selection macros should be in config.h, not on CPPDEFINES

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Done
    • Icon: Blocker - P1 Blocker - P1
    • legacy-0.10.0
    • None
    • Build

    Description

      For the server, it is appropriate for the macros that select the AtomicWord/AtomicIntrinsics to be CPPDEFINES, since there is no ABI. However, for the driver, we must make these part of the config.h header so the choice of implementation is fixed at build time, since otherwise the consuming client would need to define, or risk an ODR violation.

      Attachments

        Activity

          People

            andrew.morrow@mongodb.com Andrew Morrow (Inactive)
            andrew.morrow@mongodb.com Andrew Morrow (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: