C++11 build of driver is broken w.r.t. timegm

XMLWordPrintableJSON

    • None
    • None
    • None
    • None
    • None
    • None
    • None

      In C+11 builds, we request C99, which makes timegm not exist, so we use the vendored copy. As it turns out, modern C+ compilers emit a warning/error when building that file:

      rc/third_party/tz/timegm.c: In function 'gmtsub':
src/third_party/tz/timegm.c:186:14: error: the comparison will always evaluate as 'true' for the address of 'gmtmem' will never be NULL [-Werror=address]
   if (gmtptr != NULL)
              ^

              Assignee:
              Adam Midvidy (Inactive)
              Reporter:
              Andrew Morrow (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: